1597897 - Candidate window position is invalid when using physical keyboard

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P3)

Description

[Makoto Kato [:m_kato]]

Attachment: Fenix

candidate window of IME is overlapped at inputting test. Fennec works well.

But floating mode of candidate window is physical keyboard only mode

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Fennec

Comment 2

[Emily Toop (:fluffyemily)]

IME

Comment 3

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=eb577b937ff2e7493a637447702ba13e4b9ea848

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1597897 - Use LayoutDeviceIntRect directly for IME composition rect. r=#geckoview-reviewers

Actually nsIWidget::GetDefaultScale() will always return 1.0 on GeckoView
([*1] and [*2]). When calculating CSS rect, although we have to consider zoom
factor too, but ConvertRectArrayToJavaRectFArray doesn't yet. So then,
GeckoView will notify IME of incorrect rect.

Now we already know the layout device rect, so we should use it directly
instead of converting to CSS unit.

Also, there is no way to add tests since we cannot have the physical keyboard
tests on geckoview-junit.

*1 https://searchfox.org/mozilla-central/rev/4646b826a25d3825cf209db890862b45fa09ffc3/widget/android/nsWindow.cpp#1919-1928
*2 https://searchfox.org/mozilla-central/rev/4646b826a25d3825cf209db890862b45fa09ffc3/widget/android/ScreenHelperAndroid.cpp#39-41

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11377c82f206
Use LayoutDeviceIntRect directly for IME composition rect. r=geckoview-reviewers,agi

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/11377c82f206

Comment 7

[Chris Peterson [:cpeterson]]

Moving some keyboard bugs to the new GeckoView::IME component.