Closed Bug 1597918 Opened 5 months ago Closed 5 months ago

Port bug 1596724 - Update input[type="number"]

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: darktrojan, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1596724 changed the CSS relating to number inputs and their inner elements. As a result our inputs are oversized again, and calendar/test/browser/eventDialog/browser_eventDialogSize.js has broken on Linux. (It's probably just luck that it still passes on other platforms.)

We need to go through all of our number inputs and add the class input-number-mozbox to them.

Magnus, have you got someone with some spare time for this?

Flags: needinfo?(mkmelin+mozilla)

I've added the class to every number box because it fixes also a small gap around the spin buttons, at least on Windows.

Is it okay that you review all? If you want a calendar peer, please add one.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9110296 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9110296 [details] [diff] [review]
1597918-input-number-mozbox.patch

Review of attachment 9110296 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. In the commit message please change "with" to "to use"
Attachment #9110296 - Flags: review?(mkmelin+mozilla) → review+

Thanks, fixed the commit message.

Attachment #9110296 - Attachment is obsolete: true
Attachment #9110361 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/addad8f98bfc
Port bug 1596724: Update input[type="number"] to use class="input-number-mozbox". r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.