1597918 - Port bug 1596724 - Update input[type="number"]

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

Bug 1596724 changed the CSS relating to number inputs and their inner elements. As a result our inputs are oversized again, and calendar/test/browser/eventDialog/browser_eventDialogSize.js has broken on Linux. (It's probably just luck that it still passes on other platforms.)

We need to go through all of our number inputs and add the class input-number-mozbox to them.

Magnus, have you got someone with some spare time for this?

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1597918-input-number-mozbox.patch

I've added the class to every number box because it fixes also a small gap around the spin buttons, at least on Windows.

Is it okay that you review all? If you want a calendar peer, please add one.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9110296 [details] [diff] [review]
1597918-input-number-mozbox.patch

Review of attachment 9110296 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. In the commit message please change "with" to "to use"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1597918-input-number-mozbox.patch

Thanks, fixed the commit message.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/addad8f98bfc
Port bug 1596724: Update input[type="number"] to use class="input-number-mozbox". r=mkmelin