Closed Bug 1597928 Opened 4 months ago Closed 4 months ago

Snap repackage: Stop fetching scripts from the hg.mozilla.org archive endpoint

Categories

(Release Engineering :: Release Automation: Snap, enhancement)

enhancement
Not set

Tracking

(firefox-esr68 fixed, firefox70 wontfix, firefox71 verified, firefox72 fixed)

VERIFIED FIXED
Tracking Status
firefox-esr68 --- fixed
firefox70 --- wontfix
firefox71 --- verified
firefox72 --- fixed

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1596135 comment 9, :jlund called out a release blocker because the snap-repackage task cannot download a tarball of the source code via hg.mozilla.org. I hit the same issue, when I wanted to test bug 1591751 out on try.

At the beginning, I started to look into :sheehan's recommendation (bug 1596135 comment 11), but I later realized there's a smarter fix to make. Nowadays, the firefox-snap docker image is rebuilt whenever the content of [1] changes. This folder contains everything the repackage task needs, but interestingly, it's not baked in the docker image. We keep downloading these files from hg.mozilla.org directly. I traced back the origin of this behavior and it was first introduced in bug 1297519[2], that is to say, at the very beginning of the Snap project. At that time, we didn't have docker images automatically built in tree, we pulled images from dockerhub[3]. Docker images in tree were made possible by bug 1343107.

Therefore, we've carried over this old behavior for more than 3 years. We can now use better tools.

[1] https://hg.mozilla.org/mozilla-central/file/79821df172391d2d9ab224951b36bd8856df0fb1/taskcluster/docker/firefox-snap/
[2] https://github.com/mozilla-releng/releasetasks/commit/26caea223918afb1cd5a3448146edb0ecd2075a8#diff-51a0a141c4d0e9bb7104b16b6aa08372R39
[3] https://github.com/mozilla-releng/releasetasks/commit/26caea223918afb1cd5a3448146edb0ecd2075a8#diff-51a0a141c4d0e9bb7104b16b6aa08372R29

Thanks Julien! If the patch works as expected on today's beta, we need to uplift it on all maintained branches.

Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c338d3eee870
Snap repackage: Stop fetching scripts from the hg.mozilla.org archive endpoint r=jlund
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED

it fixed it!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.