Closed Bug 1597935 Opened 1 year ago Closed 1 year ago

Don't buffer audio inside `SourceMediaTrack`

Categories

(Core :: Audio/Video: MediaStreamGraph, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
mozilla73
Tracking Status
firefox72 --- verified
firefox73 --- verified

People

(Reporter: padenot, Assigned: jbauman)

References

Details

Attachments

(1 file, 1 obsolete file)

https://phabricator.services.mozilla.com/D51866#inline-325338:

If we want, we can make the buffering only occur in SourceMediaTrack by only appending the requested slice here: https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/dom/media/MediaTrackGraph.cpp#2381

That would fix it for the rest of the graph, and in the long term SourceMediaTrack goes away (and the buffering with it).

Priority: -- → P3

To be clear there'd still be buffering in SourceMediaTrack::mUpdateTrack->mData. Today there's also buffering in SourceMediaTrack::mSegment and that's what we want to remove.

Assignee: nobody → jbauman
Status: NEW → ASSIGNED

Update with review feedback

Depends on D54853

Attachment #9112196 - Attachment is obsolete: true
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e23ce7f96df9
Don't buffer audio inside `SourceMediaTrack`. r=pehrsons
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Comment on attachment 9111811 [details]
Bug 1597935 - Don't buffer audio inside SourceMediaTrack. r=padenot,pehrsons

Beta/Release Uplift Approval Request

  • User impact if declined: This is a blocker for bug 1600063. I missed this when requesting uplift for bug 1600063. See bug 1600063 comment 8 for details.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See bug 1600063 comment 8 for details.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple same-thread-only change that's baked on Nightly for some time.
  • String changes made/needed:
Attachment #9111811 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the initial issue with an old Nightly build 72.0a1 (Build id: 20191201093732).
Verified - Fixed in latest Nightly 73.0a1 (2019-12-16) (Build id: 20191216214733) using Windows 10, Ubuntu 18.04 and Mac OS 10.15.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

Comment on attachment 9111811 [details]
Bug 1597935 - Don't buffer audio inside SourceMediaTrack. r=padenot,pehrsons

approved for 72.0b8

Attachment #9111811 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - Fixed in latest Beta 72.0b8 (Build id: 20191218033533).

You need to log in before you can comment on or make changes to this bug.