1597935 - Don't buffer audio inside `SourceMediaTrack`

Status: VERIFIED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P3)

Description

[Paul Adenot (:padenot)]

https://phabricator.services.mozilla.com/D51866#inline-325338:

If we want, we can make the buffering only occur in SourceMediaTrack by only appending the requested slice here: https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/dom/media/MediaTrackGraph.cpp#2381

That would fix it for the rest of the graph, and in the long term SourceMediaTrack goes away (and the buffering with it).

Comment 1

[Andreas Pehrson [:pehrsons]]

To be clear there'd still be buffering in SourceMediaTrack::mUpdateTrack->mData. Today there's also buffering in SourceMediaTrack::mSegment and that's what we want to remove.

Comment 2

[Jon Bauman [:jbauman:]]

Attachment: Bug 1597935 - Don't buffer audio inside `SourceMediaTrack`. r=padenot,pehrsons

Comment 3

[Jon Bauman [:jbauman:]]

Attachment: Bug 1597935 - Don't buffer audio inside `SourceMediaTrack`. r=padenot,pehrsons

Update with review feedback

Depends on D54853

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e23ce7f96df9
Don't buffer audio inside `SourceMediaTrack`. r=pehrsons

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e23ce7f96df9

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 9111811 [details]
Bug 1597935 - Don't buffer audio inside SourceMediaTrack. r=padenot,pehrsons

Beta/Release Uplift Approval Request

• User impact if declined: This is a blocker for bug 1600063. I missed this when requesting uplift for bug 1600063. See bug 1600063 comment 8 for details.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug 1600063 comment 8 for details.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple same-thread-only change that's baked on Nightly for some time.
• String changes made/needed:

Comment 7

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue with an old Nightly build 72.0a1 (Build id: 20191201093732).
Verified - Fixed in latest Nightly 73.0a1 (2019-12-16) (Build id: 20191216214733) using Windows 10, Ubuntu 18.04 and Mac OS 10.15.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9111811 [details]
Bug 1597935 - Don't buffer audio inside SourceMediaTrack. r=padenot,pehrsons

approved for 72.0b8

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e17daec6cfa7

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 72.0b8 (Build id: 20191218033533).