1597939 - Attendees listed with white text on white background

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Dag Bakke]

Attachment: attendee.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Create 'New Event'
Invite attendees
Click in the empty field below my own email address, start typing.
A dropdown list with matching addresses appears. Choose one.

Actual results:

The attendee is added, and a new attendee can be selected in the same way in the newly created field below the one we just populated.
The attendee we just added is 'invisible', as the mail address is white text on white background.
I can highlight the text in field, or individual pieces of the text. But when not highlighted, it is invisible.

Expected results:

Attendees should be shown with text-color visible on the background-color.

Comment 1

[Dag Bakke]

I have tried a number of combinations of gtk-themes, thunderbird themes, system-color overrides, variants of overrides +++. None appears to have the slightest impact on this particular UI element.

I managed to work around this particular annoyance by editing out my preference for dark themes in the gtk config file
(.config/gtk-3.0/settings.ini)

Like this:
[Settings]
;gtk-application-prefer-dark-theme=1

Can I have an affinity for dark themes and still see my attendees? Installed gtk themes are:
Adwaita
Adwaita Dark
HighContrast
Raleigh

Comment 2

[Dag Bakke]

To clarify previous comment:

I found a workaround while writing the previous comment. Lightning appears to honor 'gtk-application-prefer-dark-theme=1', but the UI element in question becomes invisible with it.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1597939-attendee-colours.patch

Paul, to test this you need to set a dark system theme. -moz-Field is on light themes normally white, so no change on light themes but it works now on dark system themes.

Comment 4

[Paul Morris [:pmorris]]

Comment on attachment 9110254 [details] [diff] [review]
1597939-attendee-colours.patch

Review of attachment 9110254 [details] [diff] [review]:
-----------------------------------------------------------------

Tested with a dark system theme (thanks for the tip), and it looks good.  Fixes the issue.  Code changes look good.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1597939-attendee-colours-ESR.patch

Patch for ESR.
Slightly different because the textbox de-XBL changes aren't in ESR.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0402b8ff64e
Fix some background colours in attendee dialog with dark system theme. r=pmorris

Comment 7

[Geoff Lankow (:darktrojan)]

71 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/8616fc3baa19eedff16ad5ae2d135b1904ba7c02

Comment 8

[Geoff Lankow (:darktrojan)]

68.3.1:
https://hg.mozilla.org/releases/comm-esr68/rev/075bc74ab2262b9209483d8427cc41d5452b05a5