Closed
Bug 1597964
Opened 4 years ago
Closed 4 years ago
Restructure all <xul:dialog> usages such that they are not the top level element -- in chat/
Categories
(Thunderbird :: Instant Messaging, task, P2)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 73.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 1 obsolete file)
17.50 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Attachment #9110233 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•4 years ago
|
Status: NEW → ASSIGNED
Updated•4 years ago
|
Summary: Remove xul:dialog and migrate consumers to xul:window[role=dialog] with the dialog as the only child in chat/ → Restructure all <xul:dialog> usages such that they are not the top level element -- in chat/
Comment 2•4 years ago
|
||
Comment on attachment 9110233 [details] [diff] [review] Bug-1597964_remove-xul-dialog-chat-0.patch Review of attachment 9110233 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. So we don't have to change (indent) the whole file, we can keep the <dialog> at column 0. Later conversions will change stuff anyway.
Attachment #9110233 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•4 years ago
|
||
Attachment #9110233 -
Attachment is obsolete: true
Attachment #9113308 -
Flags: review+
Assignee | ||
Updated•4 years ago
|
Attachment #9113308 -
Attachment description: Bug-1597964_remove-xul-dialog-chat.patch → Bug-1597964_remove-xul-dialog-chat-1.patch
Attachment #9113308 -
Attachment filename: Bug-1597964_remove-xul-dialog-chat.patch → Bug-1597964_remove-xul-dialog-chat-1.patch
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7f136a6c0f30
Restructure all <xul:dialog> usages such that they are not the top level element in chat/. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 73.0
You need to log in
before you can comment on or make changes to this bug.
Description
•