Closed Bug 1597964 Opened 4 years ago Closed 4 years ago

Restructure all <xul:dialog> usages such that they are not the top level element -- in chat/

Categories

(Thunderbird :: Instant Messaging, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324
Blocks: 1585545
Priority: -- → P2
Attachment #9110233 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Summary: Remove xul:dialog and migrate consumers to xul:window[role=dialog] with the dialog as the only child in chat/ → Restructure all <xul:dialog> usages such that they are not the top level element -- in chat/
Comment on attachment 9110233 [details] [diff] [review]
Bug-1597964_remove-xul-dialog-chat-0.patch

Review of attachment 9110233 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. 
So we don't have to change (indent) the whole file, we can keep the <dialog> at column 0. Later conversions will change stuff anyway.
Attachment #9110233 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9110233 - Attachment is obsolete: true
Attachment #9113308 - Flags: review+
Attachment #9113308 - Attachment description: Bug-1597964_remove-xul-dialog-chat.patch → Bug-1597964_remove-xul-dialog-chat-1.patch
Attachment #9113308 - Attachment filename: Bug-1597964_remove-xul-dialog-chat.patch → Bug-1597964_remove-xul-dialog-chat-1.patch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7f136a6c0f30
Restructure all <xul:dialog> usages such that they are not the top level element in chat/. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
Regressions: 1611882
Regressions: 1717238
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: