Closed Bug 1598080 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 20345 - Fix paint worklet hidpi

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20345 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20345
Details from upstream follow.

Xida Chen <xidachen@chromium.org> wrote:

Fix paint worklet hidpi

Right now in the PaintRenderingContext2D::setTransform, we account for
the device_scale_factor_. This is wrong. It appears that internally
the recording canvas handles the device scale factor in the correct way.
Instead it should account for browser zoom.

A layout test has been changed to expect the correct result.
Screen recordings here to show that the demo is rendered correctly:
https://drive.google.com/drive/folders/1NbHlFgxBvJDvtN3wrq61uyzzIPk83FXR?usp=sharing

Bug: 970783
Change-Id: I8f2b6287fe5b0c443d7de5c8c61bfb62ae1ef42b

Reviewed-on: https://chromium-review.googlesource.com/1841530
WPT-Export-Revision: a474df0b07e2356d2bf393364c1b338a2804ab14

Component: web-platform-tests → Web Painting
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Gecko CI Results

Ran 1 tests
FAIL : 1

New tests that don't pass

/css/css-paint-api/hidpi/canvas-transform.https.html: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bc1b3021026
[wpt PR 20345] - Fix paint worklet hidpi, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.