1598133 - Revisit manual ref-counting in ProfilingStackOwner

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In bug 1445822, ProfilingStackOwner originally used the standard NS_INLINE_DECL_THREADSAFE_REFCOUNTING ref-counting macro, but that resulted in test failures due to apparent leak checks:

TEST-UNEXPECTED-FAIL | leakcheck | tab 32 bytes leaked (ProfilingStackOwner)

I believe the handling was correct, but that the leak checker may run before both the profiler and all registered threads would end, meaning that the leak checker sees still-living objects.

This bug should first verify that the handling is indeed correct (so there's no actual leaks when the program ends), and attempt to safely eliminate leak checker warnings if possible.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

ProfilingStackOwner is no more!
So I'll mark this bug here effectively fixed, because bug 1722261 removed the need for ref-counting by removing the whole class.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Simon says mark bug fixed. 😅