Closed Bug 1598189 Opened 2 months ago Closed 2 months ago

[fission] browser/base/content/test/tabs/browser_new_web_tab_in_file_process_pref.js fails

Categories

(Core :: DOM: Content Processes, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M4.1
Tracking Status
firefox73 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

Details

Attachments

(5 files, 1 obsolete file)

This test uses a configuration where web content is allowed to use file processes, and doesn't currently work with fission. This feature is off-by-default and possibly only used in some corporate environments for compatibility with their intranets.

I got distracted and fixed it, turns out it wasn't blocking my other work but there's patches to fix it now anyway.

Paul, kmag says we don't want to make this change.

Flags: needinfo?(pbone)

kmag responded on phabricator and gave another suggestion. As far as I know that's what kmag thinks, if that's not true then I don't know.

Flags: needinfo?(pbone) → needinfo?(kmaglione+bmo)
Fission Milestone: M6 → M4.1
Flags: needinfo?(kmaglione+bmo)
Attachment #9110445 - Attachment is obsolete: true

Kmag said

Yeah. It might be a good idea to update the test to check that we ignore the pref with Fission enabled.

I agree, so this is what I'll do now. Have the test verify that the pref does nothing when fission is enabled.

Refactor the browser_new_web_tab_in_file_process_pref.js test to make it
easier to add new tests here and reuse some code.

Check that that the process type starts of as a file process type.

Depends on D54666

Attachment #9111485 - Attachment description: Bug 1598189 - Refactor browser_new_web_tab_in_file_process_pref.js r=kmag → Bug 1598189 - pt 1. Refactor browser_new_web_tab_in_file_process_pref.js r=kmag
Attachment #9111486 - Attachment description: Bug 1598189 - Add a new check to browser_new_web_tab_in_file_process_pref.js r=kmag → Bug 1598189 - pt 2. Add a new check to browser_new_web_tab_in_file_process_pref.js r=kmag
Attachment #9111487 - Attachment description: Bug 1598189 - Check for the correct behaviour with the pref off r=kmag → Bug 1598189 - pt 4. Check for the correct behaviour with the pref off r=kmag
Attachment #9111488 - Attachment description: Bug 1598189 - allowLinkedWebInFileUriProcess is ignored for fission r=kmag → Bug 1598189 - pt 5. allowLinkedWebInFileUriProcess is ignored for fission r=kmag
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bba188ad5d4
pt 1. Refactor browser_new_web_tab_in_file_process_pref.js r=kmag
https://hg.mozilla.org/integration/autoland/rev/94a757a59eec
pt 2. Add a new check to browser_new_web_tab_in_file_process_pref.js r=kmag
https://hg.mozilla.org/integration/autoland/rev/72ba1e7bf774
pt 3. Use SpecialPowers.spawn rather than ContentTask.spawn r=kmag
https://hg.mozilla.org/integration/autoland/rev/71960636b063
pt 4. Check for the correct behaviour with the pref off r=kmag
https://hg.mozilla.org/integration/autoland/rev/17b1507ecd8d
pt 5. allowLinkedWebInFileUriProcess is ignored for fission r=kmag
You need to log in before you can comment on or make changes to this bug.