Linux debug build failing at make check
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
2.73 KB,
patch
|
rjl
:
review+
|
Details | Diff | Splinter Review |
The Linux debug builds are failing a bunch of tests at testing/xpcshell/selftest.py. The logs show this assertion failure:
[task 2019-11-21T01:12:27.313Z] 01:12:27 INFO - check> E PID 29564 | Assertion failure: aDefaultLocale.IsEmpty() || Locale(aDefaultLocale).IsWellFormed() (If specified, default locale must be a well-formed BCP47 language tag.), at /builds/worker/workspace/build/src/intl/locale/LocaleService.cpp:549
That makes me think bug 1571915 or bug 1581960 are the problem. Any advice, Gandalf?
Comment 1•5 years ago
|
||
I guess it is related! Can you advice me on how to run those tests locally so I can debug it?
Assignee | ||
Comment 2•5 years ago
|
||
I do make -C objdir check
and the tests in question run, but I've not seen the failure locally as I haven't got a debug build handy.
Assignee | ||
Comment 3•5 years ago
|
||
Additionally, I've no idea why the tests only fail on Linux, and why they pass for Firefox but not Thunderbird. I didn't see anything in your patches that would not also apply to Thunderbird.
Comment 4•5 years ago
|
||
Hmm, I don't have Tb set up. I can try to repro it tomorrow, but my initial guess is that some Tb specific test, or Tb specific code that fetches OS locale, uses a locale that is not recognized - "root"
, ""
, "und"
etc. passed as defaultLocale
to some negotiation in https://searchfox.org/mozilla-central/source/intl/locale/LocaleService.cpp#691
Assignee | ||
Comment 5•5 years ago
|
||
We're failing that assertion because aDefaultLocale
is "x-test", presumably because it runs after the l10n-check step. Firefox doesn't run l10n-check on debug builds, so it doesn't fail. Mac OS doesn't run l10n-check because it's disabled in the mozconfig. Windows … I dunno.
In this patch I disable l10n check on Linux and Windows via mozconfig, because that's what Firefox does, and it should fix things.
Comment 6•5 years ago
|
||
Comment on attachment 9110746 [details] [diff] [review] 1598208-disable-l10n-check-1.diff Review of attachment 9110746 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/cb5b2500f621
Disable l10n-check on debug builds; r=rjl
Assignee | ||
Comment 8•5 years ago
|
||
What I pushed differs from the patch here because I added the new lines too far down the files and mozconfig.automation overrode them.
Description
•