The dynamic cards are wrongly displayed on one extra new tab after they are no longer eligible to be shown
Categories
(Firefox :: Messaging System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | affected |
People
(Reporter: acupsa, Unassigned)
References
Details
Attachments
(1 file)
1.63 MB,
image/gif
|
Details |
[Notes]:
- As new tabs are preloaded, cards are wrongly displayed after no longer being eligible. This will affect users who will only see two new cards and moreover, this also block us from testing different scenarios with multiple cards without having to do extra settings.
[Affected versions]:
- Firefox Nightly 72.0a1, Build ID: 20191120234543
[Affected Platforms]:
- All Windows
- All Mac
- All Linux
[Steps to reproduce]:
- Create a new Firefox profile.
- Go to the “about:config” page and add the
trailhead.firstrun.branches
with thejoin-dynamic
value. - Restart the browser and navigate to the “about:newtab” page.
- Click on the “Sign in to Sync” button and sign in.
- Open a new tab.
- Observe the displayed cards.
[Expected result]:
- The “Stay Alert to Data Breaches”, “Browse Privately” and “Instantly Send Yourself Tabs” cards are displayed.
[Actual result]:
- The “Take Your Settings with You”, “Stay Alert to Data Breaches” and “Browse Privately” cards are displayed.
[Additional notes]:
- This issue is reproducible with all the dynamic cards when clicking the CTA button or taking an action that makes the card no longer being eligible to be displayed, (e.g. the Multidevice card is still displayed on a new tab after syncing with another device).
- This issue is not reproducible when opening a new window.
- Attached a screen recording of the issue.
Comment 1•5 years ago
•
|
||
This issue is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1595074 where preloaded tab doesn't get updated with new content.
Because of this issue user will see old content for at least one more tab. One option to fix this issue for dynamic triplets is to set event listeners that listens to below events and broadcast CLEAR_MESSAGE to all tabs ( opened and preloaded)
a) User has logged into sync
b) User has connected to another device
c) User has signed up for monitor
This option has limitation of just addressing above cases provided we have events available, closing this issue as duplicate of 1595074 and moving discussion on prioritizing this fix for 72 in 1595074
Updated•5 years ago
|
Description
•