Closed
Bug 1598304
Opened 5 years ago
Closed 5 years ago
isTextInParameters is doing too much
Categories
(DevTools :: Console, task, P1)
DevTools
Console
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
isTextInParameters (devtools/client/webconsole/reducers/messages.js#1328-1340) calls getAllProps, which builds a Set of all the non-primitive items there is in the parameters of a given message.
This is wasteful as we only need to mach against one of those.
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
We don't need to build an array of all the serializable data we
can find in parameters. We can loop through them and exit as
soon as we match the text filter.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1558fc0de9b Optimize isTextInParameters in messages reducer. r=Honza.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•