Closed Bug 1598307 Opened 1 year ago Closed 4 months ago

[obsolete] Move BoxModelHighlighter to parent process so it can highlight nodes in oop iframes

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rcaliman, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(5 files)

+++ This bug was initially created as a clone of Bug #1572651 +++

This is bug tracks an alternative implementation to Bug 1572651 using JSWindowActors for communication between content process and parent process.

Context

With Fission, nodes from out-of-process iframes need to still be highlighted when hovered in the markup view and when using the node picker. The existing highlighters approach means each iframe will get its own highlighter which will be cut off at the edges of the iframe.

Approach

We need a way to draw the highlighter outside of iframes. One viable approach is to draw the highlighter in the global browser window (parent process) and position it so it overlaps the target node which lives in the content process.

We need a way to observe the position and geometry of the target node (content process) and communicate it to the highlighter (parent process. JSWindowActors are useful for this. They are spawned into parent/child pairs and can communicate across the divide.

Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Blocks: 1601346
Whiteboard: dt-fission-reserve → dt-fission-m2-mvp
See Also: → 1413099

Tracking for Fission Nightly (M6)

Fission Milestone: --- → M6
Status: NEW → ASSIGNED
Priority: P3 → P1
Blocks: 1607756
Blocks: 1623667
Blocks: 1623906

Tentatively moving P1 Fission M6 bugs to M6a.

Fission Milestone: M6 → M6a
Summary: Move BoxModelHighlighter to parent process so it can highlight nodes in oop iframes → Make the BoxModelHighlighter compatible with Fission
No longer depends on: 1572651

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6a → M6c
No longer blocks: 1623906
Summary: Make the BoxModelHighlighter compatible with Fission → Move BoxModelHighlighter to parent process so it can highlight nodes in oop iframes
No longer blocks: 1623667
No longer blocks: 1607756
Priority: P1 → P3
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve
No longer blocks: 1572662
No longer blocks: 1572654
No longer blocks: 1601346

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M6c → MVP
Assignee: rcaliman → nobody
Status: ASSIGNED → NEW
Summary: Move BoxModelHighlighter to parent process so it can highlight nodes in oop iframes → [obsolete] Move BoxModelHighlighter to parent process so it can highlight nodes in oop iframes

We've taken a different approach with Bug 1646028 whereby we keep highlighters rendering in the content process in their respective frames and reconcile which one is visible on the client.

This obsoletes all bugs required to make highlighters work in the parent process and cross-process communication.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WONTFIX
Fission Milestone: MVP → ---
Whiteboard: dt-fission-m2-reserve
You need to log in before you can comment on or make changes to this bug.