1598323 - TypeError: unorderable types: NoneType() > int()

Status: RESOLVED DUPLICATE of bug 1640249

(Remote Protocol :: Marionette, defect, P3)

Description

[Rishi Gupta (:rgpt)]

Steps to reproduce:
$ python3 mach marionette-test testing/marionette/harness/marionette_harness/tests/unit/test_accessibility.py

Actual results:
TypeError: unorderable types: NoneType() > int()

File "/home/rgpt/Desktop/mozilla/mozilla-unified/testing/marionette/mach_commands.py", line 109, in marionette_test
return run_marionette(tests, topsrcdir=self.topsrcdir, **kwargs)
File "/home/rgpt/Desktop/mozilla/mozilla-unified/testing/marionette/mach_commands.py", line 58, in run_marionette
failed = MarionetteHarness(MarionetteTestRunner, args=vars(args)).run()
File "/home/rgpt/Desktop/mozilla/mozilla-unified/testing/marionette/harness/marionette_harness/runtests.py", line 71, in run
runner.run_tests(tests)
File "/home/rgpt/Desktop/mozilla/mozilla-unified/testing/marionette/harness/marionette_harness/runner/base.py", line 917, in run_tests
self.run_test_sets()
File "/home/rgpt/Desktop/mozilla/mozilla-unified/testing/marionette/harness/marionette_harness/runner/base.py", line 1105, in run_test_sets
elif self.total_chunks > len(self.tests):

Expected results:
It should have worked with py3 also as it does on py2

Comment 1

[Rishi Gupta (:rgpt)]

@whimboo could you please help me on this ? the default value of total_chunks in init must have been 1.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's me you want to have feedback from. I will have to look into that, and may not get to that today.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

If total_chunks is of type None it would mean that None is passed into BaseMarionetteTestRunner.__init__(). Please check the caller tree by going up level by level where this wrong value comes from.

Comment 4

[Bob Clary [:bc] (inactive)]

I believe this was fixed by Bug 1640249

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Indeed, I can remember to have reviewed that part.