1598337 - Thunderbird crashes when open attached file with CrossOver application.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Sławek Ajon]

Attachment: Thunderbird_Crash_Report.txt

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

When opening file attached to the message with application running with CrossOver (Word 2016, Excel 2016), Thunderbird crash. The same happened with Firefox, when trying to open downloaded files.

Actual results:

Firefox or Thunderbird crash.

Expected results:

Firefox or Thunderbird should not crash and file should open with selected application.

Comment 1

[Wayne Mery (:wsmwk)]

What are your crsah IDS.? see https://support.mozilla.org/en-US/kb/mozilla-crash-reporter-tb#w_viewing-crash-reports

Comment 2

[Sławek Ajon]

I've issued several reports. The list of last five below:
1.bp-4b965f00-f496-4cc6-8e0c-620130191119 19/11/2019, 16:42
2. bp-26e046c5-3fd7-4783-bdc7-8e0140191111 11/11/2019, 15:15
3. bp-48db1aa9-4ded-492d-b648-3d43f0191111 11/11/2019, 14:24
4. bp-0dead089-7fca-4622-ac9f-730ed0191108 08/11/2019, 08:22
5. bp-8780dabf-90bd-4407-88a7-feeb10181110 10/11/2018, 08:35

Comment 3

[Magnus Melin [:mkmelin]]

From the first one, looks like crash at https://hg.mozilla.org/releases/mozilla-esr68/annotate/tip/widget/gtk/nsApplicationChooser.cpp#l92
-> fileWithFullPath doesn't get set so nsDependentCString on it will crash

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1598337 - add null check to prevent crash at nsApplicationChooser::Done. r=karlt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1330041fa897
add null check to prevent crash at nsApplicationChooser::Done. r=karlt

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1330041fa897

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9112672 [details]
Bug 1598337 - add null check to prevent crash at nsApplicationChooser::Done. r=karlt

Beta/Release Uplift Approval Request

• User impact if declined: Can crash.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null check to prevent crash.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Prevents crash.
• User impact if declined: Crash under certain circumstances.
• Fix Landed on Version: 73
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only adding null check to prevent crash.
• String or UUID changes made by this patch:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9112672 [details]
Bug 1598337 - add null check to prevent crash at nsApplicationChooser::Done. r=karlt

approved for 72.0b2

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/8dbe22d47385

Comment 10

[Sławek Ajon]

Dear All,

Thank you very much for your support. This morning, I've tested nightly build of Firefox. It doesn't crash any more but I you can't select application running with CrossOver to open this file either. I don't think this is a right solution for this problem. Other application can open downloaded files directly from firefox, no issue.

Regards

Comment 11

[Magnus Melin [:mkmelin]]

It's the right solution to fix the crash. Why g_find_program_in_path fails to find what it needs in your case - I don't know, but the function is expected to return null when it's not finding the program, so it's not unexpected in that regard: https://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-find-program-in-path

Comment 12

[Daniel Bodea [:danibodea]]

Hi, Sławek Ajon! I am attempting to verify the fix for this issue. Can you explain what exactly you mean by "application running with CrossOver"?
CrossOver appears to be some kind of a program that lets you open Windows apps on MacOS or Linux.

Which OS do you use and how exactly do you do it?
Thank you for your contribution!

Comment 13

[Sławek Ajon]

Hi Daniel,

CrossOver is an front end for wine. You can find more details about this application under the link below:

https://www.codeweavers.com/

Please let me know, if you need any more clarification or assistance for your test.

Regards, Sławek

PS. CrossOver works with bottles. If you like, I can share with you a bottle with office 2016 already installed. Probable, you will have troubles with license but that should not affect your testing.

Comment 14

[Daniel Bodea [:danibodea]]

Yes, I would like detailed steps to reproduce so I won't invest much time in installation and investigation. If possible, of course.

Comment 15

[Sławek Ajon]

Dear Daniel,

Sorry for late response, family matters.

Below you will find a step by step procedure to reproduce.

1. Download CrossOver from link in my previous post.
2. Install CrossOver
3. Import Bottle Archive which I will provide you with wetransfer download link. You should receive on your email address.
4. Try to open Word or Excel document from Firefox or Thunderbird.

Before the fix was put in place, firefox and thunderbird crashes. Normally selected application should open the file.

Good luck. Please let me know in case of any questions.

Regards, Sławek

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9112672 [details]
Bug 1598337 - add null check to prevent crash at nsApplicationChooser::Done. r=karlt

Simple crash fix. Approved for 68.4esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/b45333a30b6c

Comment 18

[Daniel Bodea [:danibodea]]

I have attempted to reproduce this issue, but I was unable. It appears that the Office 2016 bottle that I received does not work properly on my Ubuntu 18 test machine. The Office does not open correctly at all. Also, the 4th step from comment 15 ("Try to open Word or Excel document from Firefox or Thunderbird.") is too vague. I don't know how that should be done.

Sławek Ajon, I would like to ask you to help by verifying the fix in the required channels. Will you be able to do that?
What you need to do is download a fixed build from the fixed channels and verify each:

1. Nightly73: http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
2. Beta72: http://archive.mozilla.org/pub/firefox/candidates/72.0b9-candidates/build1/
3. ESR68: http://archive.mozilla.org/pub/firefox/releases/68.3.0esr/

Thank you for your contribution!