Closed Bug 1598445 Opened 5 years ago Closed 4 years ago

Should yarn be a devDependency and in the top-level package.json?

Categories

(DevTools :: General, task, P2)

Product:
DevTools
Component:
General
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dmosedale, Assigned: jlast)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed by bug 1605231])

It's not clear to me from a quick look at 1494796, why it's (currently) useful to have yarn at the top-level package.json. I'd love to get a bit more context about how this is helpful. (We'll have to vendor it in as part of the vendoring project sooner rather than later if it wants to stay there).

Separately from that, I think there are two things that want to be tweaked where ever it lives:

  • this looks like it wants to be a devDependency, not a dependency. Correct?
  • it would be good to strictly pin the version that's being used, as we do with the rest of the packages, so that the version installed is deterministic.

Jason, can you please chime in on this bug? Any idea what the priority of this should be?

Flags: needinfo?(jlaster)

Thanks for looking into this Dan.

yarn is definitely a devDependency. I don't see a problem with promoting it to the top either.

Flags: needinfo?(jlaster)
Priority: -- → P2

Fixed by bug 1605231

Assignee: nobody → jlaster
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1605231
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1605231]
You need to log in before you can comment on or make changes to this bug.