[wpt-sync] Sync PR 20373 - Implement new pseudoElement interface on KeyframeEffect
Categories
(Core :: DOM: Animation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20373 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20373
Details from upstream follow.
George Steel <gtsteel@google.com> wrote:
Implement new pseudoElement interface on KeyframeEffect
Rename the KeyframeEffect::target() method to BlinkTarget().
This and the backing variable target_ will still return a blink::PseudoElement.
Refactor all native callers to use this new name.Make target() return the originating element if target_ is a PseudoElement.
Add PseudoElement() property whiich returns a pseudo-selector is target_
is a pseudo-element.
Update setters for both these parts which attempt to preserve the other value.
Attempting to select a non-existent pseudo-element will set a null target.Add pseudoElement option to KeyframeEffect constructor.
Replace duplicate copy in Animatable::animate with function call.Change-Id: Id7d16ea6966c533e56d1170462ff60a79b277fd5
Reviewed-on: https://chromium-review.googlesource.com/1921343
WPT-Export-Revision: d1c22a67e6d5c11e3b625f1b063b7ea5e9409686
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 11 subtests
Status Summary
Firefox
OK : 1
PASS: 10
FAIL: 1
Chrome
OK : 1
PASS: 9
FAIL: 1
Safari
OK : 1
PASS: 10
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-animations/interfaces/KeyframeEffect/style-change-events.html
All property keys are recognized: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 4•6 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 11 subtests
Status Summary
Firefox
OK : 1
PASS: 10
FAIL: 1
Chrome
OK : 1
PASS: 9
FAIL: 1
Safari
OK : 1
PASS: 10
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-animations/interfaces/KeyframeEffect/style-change-events.html
All property keys are recognized: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 5•6 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 11 subtests
Status Summary
Firefox
OK : 1
PASS: 10
FAIL: 1
Chrome
OK : 1
PASS: 9
FAIL: 1
Safari
OK : 1
PASS: 10
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-animations/interfaces/KeyframeEffect/style-change-events.html
All property keys are recognized: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 7•6 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 11 subtests
Status Summary
Firefox
OK : 1
PASS: 10
FAIL: 1
Chrome
OK : 1
PASS: 9
FAIL: 1
Safari
OK : 1
PASS: 10
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-animations/interfaces/KeyframeEffect/style-change-events.html
All property keys are recognized: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 8•6 years ago
|
||
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1affafb66f3a
https://hg.mozilla.org/mozilla-central/rev/d0fbb2559b34
Description
•