1598447 - "deletion-request" is new in Firefox 72, not Firefox 70

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Chris H-C :chutten|PTO (back March 17)]

https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/deletion-request-ping.html erroneously says that the "deletion-request" ping was introduced in Firefox 70. It should say Firefox 72 instead.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code
   • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions:
3. Start working on this bug. You'll be editing toolkit/components/telemetry/docs/data/deletion-request-ping.rst to replace "70" with "72".
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
4. Ensure your change works by running mach doc. Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Elliot Matthew]

Hi, I'm getting started with Phabricator. Think I could give this bug a shot?

Comment 2

[Chris H-C :chutten|PTO (back March 17)]

Certainly! I've assigned it to you. Let me know if you have any questions.

Comment 3

[Elliot Matthew]

Hi, Im trying, hg pull, then hg update to update my code. However i run into a problem updating, because i have made local edits. Any way to undo local edits?

Comment 4

[Chris H-C :chutten|PTO (back March 17)]

I'm not familiar with mercurial, but the internet suggests maybe hg update --clean might do the trick. There's usually someone who knows hg on #introduction on IRC if you need some hands-on help.

Comment 5

[Chris H-C :chutten|PTO (back March 17)]

Are you still working on this patch? Anything I can help with? Or should I unassign it for now?

Comment 6

[Chris H-C :chutten|PTO (back March 17)]

Clearing assignee for inactivity.

Comment 7

[louiscontant]

Hi,

I would like to have this task assigned to me.

Comment 8

[louiscontant]

Attachment: Bug 1598447 - Change the firefox version on the telemetry ping documentation to display.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/346f1f020530
Change the firefox version on the telemetry ping documentation to display. r=janerik

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/346f1f020530