[wpt-sync] Sync PR 20328 - [scroll-to-text-fragment] Replace BroadcastChannel with WPT Stash
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20328 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20328
Details from upstream follow.
Nick Burris <nburris@chromium.org> wrote:
[scroll-to-text-fragment] Replace BroadcastChannel with WPT Stash
BroadcastChannel was not supported on all platforms, and also caused
some flakiness. This patch replaces BroadcastChannel usage with WPT
Stash.Also adds a META.yml.
Bug: https://github.com/web-platform-tests/wpt/issues/20269
Change-Id: I25f7fa30da59c156de88ee5f7259152369493629
Reviewed-on: https://chromium-review.googlesource.com/1925428
WPT-Export-Revision: b4842f939d21813a6157fbe24842ee3c20390f9d
Assignee | ||
Comment 1•5 years ago
|
||
PR 20328 applied with additional changes from upstream: c1c27e227840599ad09a150f74851cbd9238c9b9, 186457c2f6c0f52d9939cddeefeaebcff38d681b, fb6ccd56fa8c857991e49c59fdde160fabfe8507
Assignee | ||
Comment 2•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b038f0b104f73d702656b6c0582218d4fe858e9c
Assignee | ||
Comment 3•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 38 subtests
Status Summary
Firefox
OK : 2
PASS : 1
FAIL : 42
Chrome
PASS : 1
FAIL : 14
TIMEOUT: 4
NOTRUN : 26
Safari
TIMEOUT: 4
NOTRUN : 41
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/scroll-to-text-fragment/scroll-to-text-fragment-security.html
Test that a text fragment directive requires a user activation (user_activation=false).: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test that a text fragment directive is not activated within an iframe.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test that a text fragment directive requires a user activation (user_activation=true).: FAIL (Chrome: FAIL, Safari: TIMEOUT)
Test that a text fragment directive is not activated when there is a window opener (noopener=true).: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test that a text fragment directive is not activated when there is a window opener (noopener=false).: FAIL (Chrome: TIMEOUT, Safari: NOTRUN)
/scroll-to-text-fragment/scroll-to-text-fragment.html
Test navigation with fragment: Fragment directive with percent encoded syntactical characters "&,-" should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-matching text directive with existing element fragment should scroll to element.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Generic fragment directive with existing element fragment should scroll to element.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Exact text with prefix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by suffix should match the suffixed text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should match when context terms are separated by node boundaries.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-matching text directive with nonexistent element fragment should not match and not scroll.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-whole-word exact text with spaces should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix and suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should not scroll to hidden text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by prefix should match the prefixed text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with no context should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix and nonmatching suffix should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple non-whole-word exact texts should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple text directives and a non-text directive should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive should match text within shadow DOM.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with non-matching startText should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive with invalid syntax (context terms without "-") should not parse as a text directive.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive with existing element fragment should match and scroll into view text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by prefix and suffix should match the text with the given context.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with non-matching endText should not match.: FAIL (Chrome: TIMEOUT, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text range with suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive with nonexistent element fragment should match and scroll into view text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with nonmatching prefix and matching suffix should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with prefix and suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Fragment directive with all TextMatchChars should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with percent encoded spaces should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: A non-matching text directive followed by a matching text directive should match and scroll into view the second text directive.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive should not scroll to display none text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Uppercase TEXT directive should not parse as a text directive.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Multiple matching exact texts should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Fragment directive with percent encoded non-ASCII unicode character should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with no context should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should horizontally scroll into view.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive followed by non-text directive should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b856eb0e4aea [wpt PR 20328] - [scroll-to-text-fragment] Replace BroadcastChannel with WPT Stash, a=testonly https://hg.mozilla.org/integration/autoland/rev/b1680178796c [wpt PR 20328] - Update wpt metadata, a=testonly
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b856eb0e4aea
https://hg.mozilla.org/mozilla-central/rev/b1680178796c
Description
•