1598468 - Temporarily stop emitting Target.receivedMessageFromTarget events due to massive spamming in the console

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While I cannot see any of those events when running some Puppeteer tests, we seem to emit a new event for each and every method. This completely spams the console, and makes it very hard to follow the order of received events.

So we seem to inappropriately sending out all those events. It would be good to know for which protocol message we have to send this event.

Here the description of the CDP event:

Notifies about a new protocol message received from the session (as reported in attachedToTarget event).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As I can see in the CDP sources the event should only occur when the session is NOT flattened:

https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/target_handler.cc?dr=C&g=0&l=368-369

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As replied by Andreas on IRC it will be fine to temporarily disable sending those events.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1598468 - [remote] Temporarily stop emitting the "Target.receivedMessageFromTarget" event. r=#remote!

This event is currently sent for each and every message,
and as such duplicates every log entry as displayed when
having the Puppeteer debug logs turned on.

Until we can fix it to behave correctly, it should be
disabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f859313703c9
[remote] Temporarily stop emitting the "Target.receivedMessageFromTarget" event. r=remote-protocol-reviewers,ato

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f859313703c9