Closed Bug 1598518 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 20384 - Revert "[sms] Implement AbortController for SMSReceiver API"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20384 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20384
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:

Revert "[sms] Implement AbortController for SMSReceiver API"

This reverts commit 331d40099623dd97e57ddd3361decbfdd9a0e8b1.

Reason for revert: Seems to fail leak tests (see crbug.com/1027386)

Original change's description:

[sms] Implement AbortController for SMSReceiver API

This change allows developers to use the SMS Receiver API with the Abort
Controller to cancel once the API is called. This will help developers with
flows for retrying and sending a new code and they want to abort the previous
call they made to the API. If the InfoBar is up during abort, it will
leave the InfoBar open while returning an AbortError to the website. If
another request is made while the InfoBar for 1st request is still open (after
abort), upon clicking 'Verify' the SMS retrieved for the 1st request will
return to the 2nd request.

Bug: 976401
Change-Id: I132800f2954fdc370172dcd03789d3f08bcc4040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866914
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Commit-Queue: Ayu Ishii \<ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717710}

TBR=dcheng@chromium.org,reillyg@chromium.org,goto@chromium.org,ayui@chromium.org

Change-Id: I21501bd728a8b3679b5b594751ee0ea20a1d8e83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 976401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930275
Reviewed-by: Darren Shen \<shend@chromium.org>
Commit-Queue: Darren Shen \<shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718000}

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 3 tests and 52 subtests

Firefox

OK : 3
PASS : 23
FAIL : 27

Chrome

OK : 3
PASS : 23
FAIL : 27

Safari

OK : 3
PASS : 23
FAIL : 27

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c914cca3254a
[wpt PR 20384] - Revert "[sms] Implement AbortController for SMSReceiver API", a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.