1598541 - Highlight the dismissed doorhanger icon shown when a password field is modified

Status: NEW

(Toolkit :: Password Manager, enhancement, P3)

Description

[Sam Foster [:sfoster] (he/him)]

When a password field is edited, and the dimissed doorhanger shown, the anchor element should get a blue "attention" highlight

This is currently driven by the notifySaved argument on the promptToShowPassword / promptToChangePassword LoginManagerPrompter methods, but that argument is also used to trigger the "saved" toast when we auto-save a login for generated passwords. Teasing these functions apart probably means updating the signature to use a jsval options object so we can pass separate flags as properties for attention, notifySaved, dismissed, etc.

Comment 1

[Matthew N. [:MattN]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #0)

When a password field is edited, and the dimissed doorhanger shown, the anchor element should get a blue "attention" highlight

Why? Isn't that going to conflate the meaning of the blue icon? Right now blue means a login was "automatically saved" but that wouldn't be the case here.

Comment 2

[Sam Foster [:sfoster] (he/him)]

The goal here is to highlight the new/changed dismissed doorhanger (the key icon in the address bar.)
Using the same blue attention color we use for notifying when an login has been auto-saved might be confusing, so some other visual treatment - a small animation or different highlight color - would be good.