Open
Bug 1598609
Opened 5 years ago
Updated 2 years ago
Memory leak in RequestResolver::GetStorageEstimate after calling QueryInterface
Categories
(Core :: Storage: Quota Manager, defect, P2)
Core
Storage: Quota Manager
Tracking
()
NEW
People
(Reporter: sg, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
In https://searchfox.org/mozilla-central/rev/581466eef9269afb03d8a0dba2f50215f3a9026c/dom/quota/StorageManager.cpp#428, iid is leaked. The code seems to assume that iid is never allocated when QueryInterface returns a failure, but that is not true. When returning from nsDiscriminatedUnion::ConvertToInterface at https://searchfox.org/mozilla-central/rev/581466eef9269afb03d8a0dba2f50215f3a9026c/xpcom/ds/nsVariant.cpp#1071 with an error, it will have already been allocated.
This might also be a bug to be fixed in nsDiscriminatedUnion::ConvertToInterface.
|
||
Updated•5 years ago
|
Blocks: coverity-analysis
Keywords: coverity
|
Reporter | |
Updated•5 years ago
|
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
Version: unspecified → Trunk
|
||
Comment 1•5 years ago
|
||
The same bug exists in this other call site of GetAsInterface.
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•