1598655 - Touch Bar "search in" feature should clear out the URL from the Urlbar

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Harry Twyford]

When the user is on a page, focuses the Urlbar, and taps one of the "Search in" buttons in the Touch Bar, they would expect that the Urlbar be cleared out so that they can start typing a new search with the restriction symbol prepended, instead of the restriction symbol being prepended to the URL.

Comment 1

[Harry Twyford]

Attachment: Bug 1598655 - Touch Bar Search In feature should clear out the URL from the Urlbar. r?adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a7f5b6a794f
Touch Bar Search In feature should clear out the URL from the Urlbar. r=adw

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=277784619&resultStatus=testfailed%2Cbusted%2Cexception&revision=3a7f5b6a794f8c91d66e0ec8756af146931a39e9

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=277784619&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/cf114f3b74940ba766a8a7e9651a84bc91768da4

task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - TEST-PASS | browser/components/touchbar/tests/browser/browser_touchbar_searchrestrictions.js | The search restriction token should have been entered with stripped whitespace. - "+ moz illa " == "+ moz illa " -
[task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - Leaving test bound stripSpaces
[task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - Entering test bound clearURLs
[task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - Buffered messages finished
[task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - TEST-UNEXPECTED-FAIL | browser/components/touchbar/tests/browser/browser_touchbar_searchrestrictions.js | The search restriction token should have cleared out the URL. - "^ moz illa " == "^ " - JS frame :: chrome://mochitests/content/browser/browser/components/touchbar/tests/browser/browser_touchbar_searchrestrictions.js :: clearURLs :: line 152
[task 2019-11-23T05:13:23.273Z] 05:13:23 INFO - Stack trace:
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - chrome://mochitests/content/browser/browser/components/touchbar/tests/browser/browser_touchbar_searchrestrictions.js:clearURLs:152
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - GECKO(1789) | [Child 1792, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 52
[task 2019-11-23T05:13:23.274Z] 05:13:23 INFO - GECKO(1789) | [Child 1792, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 52
[task 2019-11-23T05:13:23.275Z] 05:13:23 INFO - GECKO(1789) | [Child 1792, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp, line 575
[task 2019-11-23T05:13:23.275Z] 05:13:23 INFO - GECKO(1789) | ++DOMWINDOW == 4 (0x124f86400) [pid = 1792] [serial = 4] [outer = 0x124971020]
[task 2019-11-23T05:13:23.275Z] 05:13:23 INFO - GECKO(1789) | [Child 1791, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1383
[task 2019-11-23T05:13:23.275Z] 05:13:23 INFO - GECKO(1789) | [Child 1791, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1383
[task 2019-11-23T05:13:23.275Z] 05:13:23 INFO - GECKO(1789) | JavaScript error: jar:file:///Users/cltbld/tasks/task_1574484628/build/application/Firefox%20NightlyDebug.app/Contents/Resources/browser/omni.ja!/components/MacTouchBar.js, line 442: TypeError: this._inputsNotUpdated is undefined
[task 2019-11-23T05:13:23.302Z] 05:13:23 INFO - Not taking screenshot here: see the one that was previously logged

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82265968a99a
Touch Bar Search In feature should clear out the URL from the Urlbar. r=adw

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/82265968a99a