1598782 - Text entry is broken with certain input fields

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P1)

Description

[Randall Barker [:rbarker]]

Can be reproduced in GVE, Fenix Nightly, and FxR v7 builds.
STR:

1. Got to google.com
2. click sign in buggon
3. Try to enter text into Email or phone text field

Actual results:

• No text is entered

Expected results:

• Text is entered into the text field.

See FxR issue: https://github.com/MozillaReality/FirefoxReality/issues/2350

Comment 1

[Imanol Fernandez]

I've done some research in FxR and GVE. This problem only happens with multiprocess enabled.

In GVE, restartInput seems to be called multiple times consecutively (about 4-5) when the issue is reproduced. Flow example:

• restartInput reason: RESTART_REASON_FOCUS toggleSoftInput:true
• restartInput reason: RESTART_REASON_CONTENT_CHANGE toggleSoftInput:false
• restartInput reason: RESTART_REASON_BLUR toggleSoftInput:false
• restartInput reason: RESTART_REASON_FOCUS toggleSoftInput:true

After that flow GeckoEditable doesn't receive IME_REPLY_EVENTevents anymore and mActions is never cleaned

Comment 2

[Emily Toop (:fluffyemily)]

IME issue.

Comment 4

[Makoto Kato [:m_kato]]

It seems JNI issue and may be race condition. When calling onImeSynchronize() and OnNatvieCall is called, but runnable is failure (maybe this->lambda.GetNativeObject() is null in Run(). It means that GeckoEditableSupport will be died.)

GeckoEditableSupport::TransferParent might destroy own if dispatcher is nothing... But I guess that dispatcher's initialization is delayed...

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1598782 - Don't destroy GeckoEditableSupport when getting focus.

NOTIFY_IME_OF_FOCUS performs lazy initialization for text dispatcher. When
GeckoViewSupport attaches GeckoEditable during initialization,
GeckoEditableSupport destroys myself.

So we should use lazy task to check whether this attach is temporary.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2571d0598f42
Don't destroy GeckoEditableSupport when getting focus. r=geckoview-reviewers,rbarker

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2571d0598f42

Comment 8

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.