Closed
Bug 159889
Opened 22 years ago
Closed 22 years ago
replace the hardcode of "@mozilla.org/preferences;1" with NS_PREF_CONTRACTID
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
VERIFIED
FIXED
People
(Reporter: Henry.Jia, Assigned: leon.zhang)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.19 KB,
patch
|
Henry.Jia
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
It's not a good idea to refer to NS_PREF_CONTRACTID using the hardcoded "@mozilla.org/preferences;1". First, the code style is not good. Second, it is more easy to be wrong using the literal than the placehold. Third, if the literal changed someday, you may need to change it everywhere. Although this may not be easy to happen. See also bug 158080 For convenience bug 154047 Assign to Leon for continuous handling
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #93235 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 93255 [details] [diff] [review] a new patch Thx, Leon. r=henry
Attachment #93255 -
Flags: review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 93255 [details] [diff] [review] a new patch sr=alecf
Attachment #93255 -
Flags: superreview+
In trunk.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
v
Status: RESOLVED → VERIFIED
QA Contact: rvelasco → Henry.Jia
You need to log in
before you can comment on or make changes to this bug.
Description
•