1598920 - mach wpt fails when pwd is not the project root

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

(Just in case it is relavent: I am on Linux, and targeting Geckoview/Firefox Android on the x86-64 emulator)

When running mach wpt ${test_name} from ${project_root}/testing/web-platform/tests I am getting the following error:

IOError: [Errno 2] No such file or directory: 'testing/config/tooltool-manifests/linux64/hostutils.manifest'

  File "/home/ng/sync/hg/mozilla-unified/testing/web-platform/mach_commands.py", line 309, in run_wpt
    return self.run_web_platform_tests(**params)
  File "/home/ng/sync/hg/mozilla-unified/testing/web-platform/mach_commands.py", line 301, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/home/ng/sync/hg/mozilla-unified/testing/web-platform/mach_commands_base.py", line 36, in run
    kwargs = wptcommandline.check_args(self.setup.kwargs_common(kwargs))
  File "/home/ng/sync/hg/mozilla-unified/testing/web-platform/mach_commands.py", line 48, in kwargs_common
    verify_android_device(self, install=True, verbose=False, xre=True, app=package_name)
  File "/home/ng/sync/hg/mozilla-unified/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 284, in verify_android_device
    _maybe_update_host_utils(build_obj)
  File "/home/ng/sync/hg/mozilla-unified/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 140, in _maybe_update_host_utils
    with open(manifest_path, 'r') as f:

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[James Graham [:jgraham]]

I think the problem here is that https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/devices/android_device.py#32 defines a relative path, which is later used indiscriminately. I think you want to add build_obj.topsrcdir to all the cases where that or TOOLTOOL_PATH are used to construct full paths.

Comment 3

[Geoff Brown [:gbrown]]

Thanks jgraham; that sounds right. I should be able to sort it out.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: Bug 1598920 - Enable android_device.py to find file paths regardless of cwd; r=

Join <topsrcdir> with MANIFEST_PATH in android_device.py. I was concerned about TOOLTOOL_PATH
also, but that is already consistently joined with <topsrcdir> before use. I think these
are the only cases that needed attention.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bbd678617bb
Enable android_device.py to find file paths regardless of cwd; r=jgraham

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5bbd678617bb