1598923 - Investigate the SDP parsing failure in wpt RTCTrackEvent-fire.html

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Somewhere in WEBRTCSDP we are using a deprecated method and a warning is leaking out during run time. Ironically the error message may be covering up the text that would help identify where it is happening. There may not be a genuine parsing error, it might be serialization code that is tripping this deprecation warning.

This is only happening on Android 7.0 x86-64 emulator on debug, so perhaps there is a configuration difference there.

The fact that this is happening at all is potentially a sign that there is an error with the Sipcc parser, and now we fail-over to the Rust parser which fails as well. If that is the case I am not sure why this wasn't failing before. The sipcc parser does seem to pass the test though, so perhaps it is error handling or failover handling.

Failing Job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6dbc282e74e93528ae04894b8fd8f14114e9ff4&selectedJob=277849940

Test Failure: TEST-UNEXPECTED-FAIL | /webrtc/RTCTrackEvent-fire.html | stream ids should be found even if msid-semantic is absent - promise_test: Unhandled rejection with value: object "OperationError: WEBRTCSDP Failed to parse SDP: SDP Parse Error on line 16: description() is deprecated; use Display

Secondary source of the error message: https://github.com/rust-lang/rust/issues/44842

To reproduce locally:

1. build for android with the x86_64 target
2. run mach wpt webrtc/RTCTrackEvent-fire.html --setpref 'media.peerconnection.sdp.alternate_parse_mode'='never' --setpref 'media.peerconnection.sdp.parser'='webrtc-sdp'
   2.A) Not sure why, but I had to manually set ADB_PATH in my environment to the copy installed in ${HOME}/.mozbuild

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I created RTCTrackEvent-fire.html.ini which forces the use of only sipcc for this test. Once this addressed, that restriction can be lifted.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a3eb72331ae2def60589b123249dd47c22f9b95

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1598923 - Fix known WEBRTCSDP issues blocking parallel parsing mode in Nightly;r?mjf

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1598923 - P2 - Add pref to select strictness of SDP parsing success;r?drno

Depends on D55211

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1598923 - P3 - Update to WEBRTC-SDP 0.3.2;r?drno

Depends on D55602

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d50ccace0fdc2d87c94214c6ebfaf273b0c4fbfd

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29714f6f39dc5ecfea7bd4875f11720ba6b9ff57

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2e39ea0a6608dbe3ab2c9476fbc10b4a662e167

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b22b313a981b72a4200377cb4dd6b82c086f799

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f42ac01db9224c078672cbd8f8f0fbf0c414aca2

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1598923 - P4 - update to WEBRTC-SDP 0.3.3;r?mjf

Depends on D55611

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1598923 - P5 - Adapt channel handling to WEBRTC-SDP changes;r?mjf

Depends on D56332

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7942c1bd3f70
Fix known WEBRTCSDP issues blocking parallel parsing mode in Nightly;r=drno

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7942c1bd3f70