Closed
Bug 1598930
Opened 5 years ago
Closed 5 years ago
getFilterContext in RecipeRunner appears to mutate ClientEnvironment
Categories
(Firefox :: Normandy Client, defect)
Firefox
Normandy Client
Tracking
()
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: rehandalal+mozilla, Assigned: rehandalal+mozilla)
References
()
Details
Attachments
(1 file)
In RecipeRunner when we run getFilterContext it mutates the original ClientEnvironment object that we are proxying instead of only affecting the proxy. This may be the source of some issues with using normandy.recipe.arguments.slug in filter expressions. Even if it's not we should not be modifying the ClientEnvironment object.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → rdalal
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87c00877e728 ClientEnvironment proxy should set values to cache r=mythmon
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•