1598979 - Device name not reported when using synced tabs menu with a screen reader

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

STR (with the NVDA screen reader):

1. Ensure you have at least one synced tab on another device.
2. Press the Firefox Account button on the toolbar.
3. Choose Synced Tabs.
4. Press down arrow until you reach the first synced tab.
   • Expected: NVDA should have reported the name of the device the tab was synced from, as well as the name of the tab.
   • Actual: It doesn't; it only reports the tab name.

The best way to fix this would be to make each client a container with role="group" and label it with the device name using aria-labelledby. Unfortunately, right now, there isn't a container element; the buttons are just appended after the label:
https://searchfox.org/mozilla-central/rev/a78233c11a6baf2c308fbed17eb16c6e57b6a2ac/browser/components/customizableui/CustomizableWidgets.jsm#789

I'm not sure whether I can safely add an intervening container here without breaking visual styling (or what element to use), so I can't fix this myself.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Thanks for the great bug report, Jamie. Can I presume this bug also affects the Synced Tabs list in the sidebar?

Hey eoger, is this bug in the right place for the Synced Tabs menu?

Comment 2

[Edouard Oger [:eoger]]

Moving to Sync so we can triage, thanks!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 4

[James Teh [:Jamie] (away returning 28 Jan)]

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #1)

Can I presume this bug also affects the Synced Tabs list in the sidebar?

Yes, though the synced tabs sidebar has a whole bunch of other problems that are far worse than this one, making it much uglier (practically unusable?) for screen reader users than the menu. I will try to get around to filing a separate bug for that.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1598979 - make the device name in the sync-tabs menu visible to screen readers. r?Gijs,Jamie

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c262b606075
make the device name in the sync-tabs menu visible to screen readers. r=Gijs,Jamie

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1c262b606075

Comment 9

[Anca Soncutean, Desktop QA]

I've reproduce this issue with Fx 72.0a1 (2019-11-24) on Windows 10 x64., using the provided steps from description.
The issue is verified fixed with Fx 74.0a1(2020-01-29) and Fx 73.0b11 on Windows 10 x64 and Windows 7x86.