1598984 - [certificate viewer] missing localizable string for l10n id 'certificate-viewer-inc-locality'

Status: VERIFIED FIXED

(Firefox :: Security, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Firefox 72.0a1 and 71.0b11 on Windows 8.1

In the certificate viewer, the l10n string id 'certificate-viewer-inc-locality' gets used but that string doesn't exist.

Steps to reproduce:

1. Open https://www.deutsche-bank.de/pk.html
2. Click on lock symbol in address bar.
3. Click on the right arrow ">" next to "Connection secure".
4. Click on more information at the bottom of the pop-up.
5. The first line mentioning Frankfurt am Main has no bold label next to it.

The source code shows that a l10n id gets used here:
<label data-l10n-id="certificate-viewer-inc-locality"></label>

A searchfox search returns nothing for certificate-viewer-inc-locality.

Comment 1

[Francesco Lodolo [:flod]]

I think it would be relatively safe to:

1. Add the missing Fluent ID to certviewer.ftl
2. "Migrate" the translation that we have for certificate-viewer-locality, given that the label and context are the same.

Comment 2

[Johann Hofmann [:johannh]]

Shayna, would you like to work on this bug? The comments above should provide enough instructions to get started, but please let me know if you need any help.

Thanks!

Comment 3

[Shayna]

Yes, I would. Thank you! I'll let you know if I need any help.

Comment 4

[Shayna]

Attachment: Bug 1598984: Add Fluent ID 'certificate-viewer-inc-locality' to certviewer.ftl r=johannh

Comment 5

[Shayna]

Attachment: Bug 1598984: Add Fluent ID 'certificate-viewer-inc-locality' to certviewer.ftl r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebedd05e0d17
Add Fluent ID 'certificate-viewer-inc-locality' to certviewer.ftl r=Gijs,fluent-reviewers

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ebedd05e0d17

Comment 8

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

Reproduced the issue using an affected Nightly build (2019-11-24), with the STR from comment 0.

The bug is verified as fixed on 76.0 RC across platforms: Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.