Closed Bug 1598984 Opened 5 years ago Closed 4 years ago

[certificate viewer] missing localizable string for l10n id 'certificate-viewer-inc-locality'

Categories

(Firefox :: Security, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- wontfix
firefox72 --- wontfix
firefox76 --- verified

People

(Reporter: aryx, Assigned: shaynajustus)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Firefox 72.0a1 and 71.0b11 on Windows 8.1

In the certificate viewer, the l10n string id 'certificate-viewer-inc-locality' gets used but that string doesn't exist.

Steps to reproduce:

  1. Open https://www.deutsche-bank.de/pk.html
  2. Click on lock symbol in address bar.
  3. Click on the right arrow ">" next to "Connection secure".
  4. Click on more information at the bottom of the pop-up.
  5. The first line mentioning Frankfurt am Main has no bold label next to it.

The source code shows that a l10n id gets used here:
<label data-l10n-id="certificate-viewer-inc-locality"></label>

A searchfox search returns nothing for certificate-viewer-inc-locality.

I think it would be relatively safe to:

  1. Add the missing Fluent ID to certviewer.ftl
  2. "Migrate" the translation that we have for certificate-viewer-locality, given that the label and context are the same.
Blocks: cert-viewer
Priority: -- → P3

Shayna, would you like to work on this bug? The comments above should provide enough instructions to get started, but please let me know if you need any help.

Thanks!

Flags: needinfo?(shaynajustus)

Yes, I would. Thank you! I'll let you know if I need any help.

Flags: needinfo?(shaynajustus)
Assignee: nobody → shaynajustus
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ebedd05e0d17
Add Fluent ID 'certificate-viewer-inc-locality' to certviewer.ftl r=Gijs,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Flags: qe-verify+

Reproduced the issue using an affected Nightly build (2019-11-24), with the STR from comment 0.

The bug is verified as fixed on 76.0 RC across platforms: Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: