1599056 - Check on new-lines for gettext-based content

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[Théo Chevalier]

Not sure if we already have some gettext checks in place, but would it be possible to prevent adding new lines when the source string doesn’t end with one in the .pot file? And similarly, to force adding a new line if the source ends with one?

compilemessages throws a fatal msgfmt error if the source/translation are not matching new lines:

Execution of msgfmt failed: /app/donate/locale/pt_BR/LC_MESSAGES/django.po:165: 'msgid' and 'msgstr' entries do not both end with '\n'
msgfmt: found 1 fatal error
CommandError: compilemessages generated one or more errors.

This fixed the error above: https://github.com/mozilla/donate-wagtail/commit/586a6a098b144e92d638e9b9f223afaa47baf423

Comment 1

[Axel Hecht [:Pike]]

http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/pofilter_tests.html#pofilter-tests-newlines is related?

More context on what msgformat is doing on https://www.gnu.org/software/gettext/FAQ.html#newline.

Comment 2

[Matjaz Horvat [:mathjazz]]

We already warn about newlines.

But I guess we should prevent overriding the check, like we do for .lang files?
https://github.com/mozilla/pontoon/blob/master/pontoon/checks/libraries/pontoon_db.py#L42-L47

Comment 3

[Axel Hecht [:Pike]]

Or we hand-craft a check like we do for .lang. The caveat about the TT check is that it also enforces in-content differences in newlines, not only end-of-content ones. Which is what we need here, AFAICT.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1512

Comment 5

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/a68edfe78dd64529557d8299cd0ebad323008c4e