Closed
Bug 1599205
Opened 5 years ago
Closed 5 years ago
ExtensionPreferencesManager API captiveURL created but addSetting was not called.
Categories
(WebExtensions :: General, defect, P1)
WebExtensions
General
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: nhnt11, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Seems like this log/warning was added in bug 1410412 and indicates that the captive portal API needs to be updated to call addSetting for each of its targets.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9111709 -
Attachment description: Bug 1599205 add onChange to captive url setting api → Bug 1599205 Part 1: add onChange to captive url setting api
|
|
||
Updated•5 years ago
|
Attachment #9111433 -
Attachment description: Bug 1599205 fix onChange event object and fix captiveUrl onChange → Bug 1599205 Part 2: fix onChange event details object
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17fcc9f9aa2f Part 1: add onChange to captive url setting api r=zombie https://hg.mozilla.org/integration/autoland/rev/f28c12cd1eab Part 2: fix onChange event details object r=zombie
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/17fcc9f9aa2f
https://hg.mozilla.org/mozilla-central/rev/f28c12cd1eab
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Comment 5•4 years ago
|
||
Hello,
If this requires manual testing could you please provide STR and add the "qe+ verify" flag?
Otherwise please set it as "qe- verify".
Thank you!
Flags: needinfo?(mixedpuppy)
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(mixedpuppy) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•