1599232 - Crash in [@ mozilla::ipc::WriteIPDLParam<T> | mozilla::dom::PSHistoryChild::SendAddEntry]

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-5da3c1d2-d458-4cbd-9140-4a6000191108.

macOS specific nightly signature which dates back to 20191108095936: https://bit.ly/2QRiG7k

The other similiar signature started on the same date: https://bit.ly/34gixhs

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d271c572a9bcd008ed14bf104b2eb81949952e4c&tochange=f414b9e6d85710f92649566c1c6511265dadd476

Top 10 frames of crashing thread:

0 XUL void mozilla::ipc::WriteIPDLParam<mozilla::dom::PSHEntryChild*&> ipc/glue/IPDLParamTraits.h:60
1 XUL mozilla::dom::PSHistoryChild::SendAddEntry ipc/ipdl/PSHistoryChild.cpp:586
2 XUL non-virtual thunk to mozilla::dom::SHistoryChild::AddEntry docshell/shistory/SHistoryChild.cpp
3 XUL nsDocShell::AddToSessionHistory docshell/base/nsDocShell.cpp:11504
4 XUL nsDocShell::UpdateURLAndHistory docshell/base/nsDocShell.cpp:11116
5 XUL nsDocShell::AddState docshell/base/nsDocShell.cpp:11069
6 XUL nsHistory::PushState dom/base/nsHistory.cpp:216
7 XUL mozilla::dom::History_Binding::pushState dom/bindings/HistoryBinding.cpp:363
8 XUL bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3218
9 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:548

Comment 1

[Marcia Knous [:marcia]]

Two URLs shows up between the 2 signatures - https://discordapp.com and https://hg.mozilla.org/mozilla-central/rev/055e0a0e4bf0. Around 12 macOS crashes only since this was reported.

Comment 2

[[:philipp]]

perhaps regressed by bug 1588491?

Comment 3

[Peter Van der Beken [:peterv]]

This code can only run when enabling the fission.sessionHistoryInParent pref. We're doing a redesign of that code, so I think this is just a WONTFIX for now.