159924 - table split up when applying paragraph style to select all

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

(please change summary to something else)

There is a problem with applying styles in Composer.
I ran across it in mail but these are the steps I can reproduce in Composer
(thanks to Daniel for helping me to enumerate them):
 * launch new computer page
 * insert default table
 * put text in each cell (not sure this step is necessary)
 * switch to source mode
 * add a space and remove it
 * switch to normal mode
 * select all
 * choose "Paragraph" from dropdown list on toolbar

notice that the table becomes 4 separate tables; this is very bad!  It should
remain as 1 table.

Comment 1

[David]

confirming:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b) Gecko/20020722

[Not positive if this is designed behavior or not]

Comment 2

[Syd Logan]

Is there a way to duplicate this without using HTML view? If not, perhaps
EDITORBASE-

Comment 3

[Joe Francis]

Attachment: patch to nsHTMLEditRules.cpp

strip out non-editible nodes from the array we use to drive block operations

Comment 4

[Joe Francis]

note: the step of going to source view *is* neccessary.  Either that or saving
the doc and reloading it.  That causes the serializer to put in a bunch of
formatting text nodes, which are neccessary to drive this bug.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Joe, this patch has CR coded for Mac only and it is hardly useable on another
platform...

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 94909 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

r=glazman

Comment 7

[Joe Francis]

daniel - simply open the patch with VC and save it out again - that will convert
it for you if you dont have an easier way.

Comment 8

[kinmoz]

Comment on attachment 94909 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

deja vu :-) ... sr=[e-mail]

Same questions about whether |nsAutoString| should be used:

+  nsString tString(*aBlockType);

Comment 9

[Joe Francis]

heh, I had merely moved that line - it's not new.  I'll open a new bug to do a
pass through editor for unneeded nsStrings.

meanwhile... fix landed on trunk.

Comment 10

[sujay]

verified in 9/5 trunk build.