Visual Metrics job doesn't support unicode content in browsertime.json
Categories
(Testing :: Performance, defect)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
Details
Attachments
(1 file)
The VisMet jobs don't support reading in browsertime.json files as Unicode, resulting in a busted job. This is problematic since both the tp6-4 and tp6-7 raptor tests include pages with unicode titles, which are embedded in the resulting browsertime.json.
This defect is caused by Python's os.open detecting the encoding to use based on the environment's LOCALE. On my local machine, it determines that it should use utf-8, but in the docker containers where the job runs it determines that it should use the ascii encoding.
|
Assignee | |
Comment 1•5 years ago
|
||
The run-visual-metrics.py script was opening the provided browsertime.json
files without specifying an encoding, which causes it to infer the encoding
from the environment. In our Docker containers, this results in the ascii
codec being chosen for opening text files. We now specifically open them as
UTF-8 to support non-ASCII content.
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62ae0fda7cb6 Open browsertime.json files for visual metrics as UTF-8 r=perftest-reviewers,rwood
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Description
•