Un-remove INTERMEDIATE_PRELOADING_* telemetry
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jcj, Assigned: keeler)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(3 files, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1553550 +++
Since Intermediate Preloading changed backends from RKV to RKV-safe, and we removed all telemetry, we actually aren't sure what the state of preloading is today. We should ... add it back in. Until we're done mucking about in this code anyway.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
This has the effect of reverting changeset 17183959c3a9 but with formatting
changes and other non-functional updates due to changes since the original
implementation was removed.
|
|
Assignee | |
Comment 2•5 years ago
|
||
(this is adapted from attachment 9043355 [details] from bug 1519273)
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9111752 [details] datareview DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions files [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) as well as the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 80. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for pre-release channels only. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. Dana's is responsible for renewing or removing the collection before it expires in Firefox 80. --- Result: datareview+
Pushed by jjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62e75880bc8f re-land intermediate preloading telemetry now that it's re-enabled r=jcj
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Comment 6•5 years ago
|
||
The test in this bug now fails when run in Thunderbird, because Thunderbird doesn't have this telemetry this time around (last time the product was unspecified so we had it too). I'm happy to create a patch wrapping the telemetry parts of the test in if (AppConstants.MOZ_APP_NAME == "firefox") {} blocks, unless you have a better idea?
|
|
||
Comment 7•5 years ago
|
||
|
||
Comment 8•5 years ago
|
||
I've a better idea. Patch coming up.
|
|
||
Comment 9•5 years ago
|
||
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 11•5 years ago
|
||
Pushed by jjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af6b936aa160 make the test_intermediate_preloads.js test collect telemetry data for all products during testing. r=jcj
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
Description
•