1599307 - What's New panel: In light theme, the background should be white

Status: VERIFIED FIXED

(DevTools Graveyard :: What's New, defect, P3)

Description

[Victoria Wang [:victoria]]

Currently the hover color is a bit hard to see in light theme since it clashes with the light gray background. We should change the background to be white instead.

Comment 1

[Cristian Fogel [:cfogel]]

Thanks again Victoria!

Notes :

• "The highlight color is correct, but the light theme background color is not. It should be white rather than gray"
• attaching a screenshot with the current issue, contrast for light theme should be improved based on the above note;
• additional info on the issue can be found here;

Affected builds:
71.0, 71.0b12, 72.0a1 (2019-11-17);

Comment 2

[Cristian Fogel [:cfogel]]

Attachment: Screenshot_2.png

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Harald, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Divyansh Sharma [:spiro]]

Hi. I am interested in taking this bug. Can you tell me in which file(s) does the code resides pertaining to the problem?

Thanks :)

Comment 5

[Cristian Fogel [:cfogel]]

Sorry for the late reply, was out of office.
Harald should have the best context for this.

Comment 6

[:Harald Kirschner :digitarald]

Thanks for offering to help, I assigned you the bug. Everything is in https://searchfox.org/mozilla-central/source/devtools/client/whats-new, src holds the CSS.

Comment 7

[Divyansh Sharma [:spiro]]

Hi Harald, thanks for directing me to the existing code. I am unable to find attribute that will change the background color. I tried to change values to different background colors to white, but to no use. Can you help me?

Comment 8

[:Harald Kirschner :digitarald]

It probably comes from li > a:hover: https://searchfox.org/mozilla-central/source/devtools/client/whats-new/src/whats-new.css#163

You could experiment with other colors from https://searchfox.org/mozilla-central/source/devtools/client/themes/variables.css#133

Comment 9

[Divyansh Sharma [:spiro]]

li > a:hover changes the hover color and not the background color. Please clarify on this.

Comment 10

[aarushivij]

Hello
Can I work on this issue?
Thanks
Aarushi

Comment 11

[Victoria Wang [:victoria]]

Looks like this panel doesn't have an existing background color. Other panels like Accessibility and Performance set a .theme-body class on the body tag which includes the right background color. That's probably what we should do here.

Divyansh, let me know if you're still interested in fixing this bug, or I can free it up for Aarushi.

Thanks!

Comment 12

[aarushivij]

@victoria
Can I work on this issue
Thanks :)
Aarushi

Comment 13

[Victoria Wang [:victoria]]

Okay, I've reassigned this to Aarushi.

Divyansh, feel free to pick up a different bug if you're interested in contributing again.

Comment 14

[aarushivij]

Attachment: Bug 1599307 - Set What's New panel background to white in light mode. r=nchevobbe.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de02a2ee356a
Set What's New panel background to white in light mode. r=nchevobbe.

Comment 16

[aarushivij]

Thanks @nchevobbe :)
Aarushi

Comment 17

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/de02a2ee356a

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 19

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

I think that's fine, even if the current color is not perfect, it's not terrible either.

Comment 20

[Cristian Fogel [:cfogel]]

Confirmed with Victoria as well, while not ideal there is an improvement from before.