1599318 - HTML textarea accepts \r character, when it should be replaced with \n

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Geoff Lankow (:darktrojan)]

When keyboard events fire "\r" at a textarea, the value could include the \r, when they should instead have a \n. Or at least, that's what I understand is supposed to happen.

Test case coming up.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1599318-testcase.diff

This is a copy of dom/tests/mochitest/keyhandling/test_textarea.html modified to show the error, and moved somewhere so that it runs on Linux.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot reproduce this bug with usual DOM operation and \r inputting key event is never fired if the source is native key event because ASCII control characters are replaced with normal characters which are inputted without modifier key. So that this is an edge case.

Comment 3

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]: I'm actually not sure we need to track. That is, it's not clear to me whether the web can encounter this behavior, per comment 2....

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Well, anyway, a patch is coming.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1599318 - `TextEditor` shouldn't put `\r` into its anonymous text node r=m_kato!

Starting from bug 1597679, HTMLTextAreaElement::GetValueInternal() stops
converting \r\n and \r with \n because it may be in hot path and the scan
cost of \r in nsContentUtils::PlatformToDOMLineBreaks() is redundant in
most cases.

However, there are still some paths to input \r. This patch makes them
call nsContentUtils::PlatformToDOMLineBreaks() if they have not done it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51ba531b4ad5
`TextEditor` shouldn't put `\r` into its anonymous text node r=m_kato

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/51ba531b4ad5