Closed Bug 1599330 Opened 3 months ago Closed 2 months ago

calendar/test/browser/eventDialog/browser_eventDialogModificationPrompt.js is failing

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Unassigned)

References

Details

(Whiteboard: [Thunderbird-testfailure: bct][thunderbird-disabled-test])

I'm going to skip the broken part of this test until bug 1599318 is fixed.

In strictly speaking, KeyboardEvent.charCode and KeyboardEvent.key coming from native key events should never be \r. Is that test using synthesizeKey("\r") intentionally? Or trying to emulate Enter or something? I mean that such test does not make sense.

Yeah, the test is somewhat weird. I'm not convinced that it even proves what it's supposed to prove any more (or if it ever did). It's emulating values that could be in the underlying data, and checking that replacing the value with the same value does not trigger a prompt to save.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/383c10de7c73
Split browser_eventDialogModificationPrompt.js in two and disable the broken part; rs=bustage-fix

Geoff, according to comment #0, could this be enabled again?

Flags: needinfo?(geoff)
Whiteboard: [thunderbird-disabled-test] → [Thunderbird-testfailure: bct][thunderbird-disabled-test]

Also, can we please record which type of test failed and the platform, which I could only work out by scrolling treeherder back by one month (not fun).

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5292ffe33f9a
Re-enable part of browser_eventDialogModificationPrompt.js fixed by bug 1599318; rs=me
Status: NEW → RESOLVED
Closed: 2 months ago
Flags: needinfo?(geoff)
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 73
You need to log in before you can comment on or make changes to this bug.