Closed Bug 1599335 Opened 4 months ago Closed 4 months ago

Remove unused SpamFilterClassifyMessage(s) functions in nsMsgDBFolder.

Categories

(MailNews Core :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: benc, Assigned: benc)

Details

Attachments

(1 file)

nsMsgDBFolder::SpamFilterClassifyMessage() and nsMsgDBFolder::SpamFilterClassifyMessages() are not exposed via XPCOM and do not seem to be used anywhere.

https://searchfox.org/comm-central/search?q=SpamFilterClassifyMessage&path=

Summary: Remove unused nsMsgDBFolder::SpamFilterClassifyMessage(s) → Remove unused SpamFilterClassifyMessage(s) functions in nsMsgDBFolder.
Assignee: nobody → benc

This patch goes on top of the ones in Bug 1594887, which should land soon.

Attachment #9112120 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9112120 [details] [diff] [review]
1599335-remove-spamfilterclassifymessage-1.patch

Review of attachment 9112120 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9112120 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Comment on attachment 9112120 [details] [diff] [review]
1599335-remove-spamfilterclassifymessage-1.patch

Review of attachment 9112120 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +2577,5 @@
>      MOZ_LOG(FILTERLOGMODULE, LogLevel::Info,
> +            ("Running Spam classification on %" PRIu32 " messages",
> +             numMessagesToClassify));
> +
> +    nsTArray<nsCString> messageURIs(numMessagesToClassify);

Interesting. That sets the capacity. Why can't I see such a pattern used elsewhere?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7dcc5e705059
Remove unused SpamFilterClassifyMessage(s) functions in nsMsgDBFolder. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.