1599335 - Remove unused SpamFilterClassifyMessage(s) functions in nsMsgDBFolder.

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Ben Campbell]

nsMsgDBFolder::SpamFilterClassifyMessage() and nsMsgDBFolder::SpamFilterClassifyMessages() are not exposed via XPCOM and do not seem to be used anywhere.

https://searchfox.org/comm-central/search?q=SpamFilterClassifyMessage&path=

Comment 1

[Ben Campbell]

Attachment: 1599335-remove-spamfilterclassifymessage-1.patch

This patch goes on top of the ones in Bug 1594887, which should land soon.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9112120 [details] [diff] [review]
1599335-remove-spamfilterclassifymessage-1.patch

Review of attachment 9112120 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9112120 [details] [diff] [review]
1599335-remove-spamfilterclassifymessage-1.patch

Review of attachment 9112120 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +2577,5 @@
>      MOZ_LOG(FILTERLOGMODULE, LogLevel::Info,
> +            ("Running Spam classification on %" PRIu32 " messages",
> +             numMessagesToClassify));
> +
> +    nsTArray<nsCString> messageURIs(numMessagesToClassify);

Interesting. That sets the capacity. Why can't I see such a pattern used elsewhere?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7dcc5e705059
Remove unused SpamFilterClassifyMessage(s) functions in nsMsgDBFolder. r=mkmelin