1599337 - Disable PHC on late beta 72 builds

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[Nicholas Nethercote [inactive]]

This is the follow-up to bug 1594595.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1599337 - Make PHC nightly-only again. r=erahm

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:njn, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3888d3abdc8a
Make PHC nightly-only again. r=erahm

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9114748 [details]
Bug 1599337 - Make PHC nightly-only again. r=erahm

Beta/Release Uplift Approval Request

• User impact if declined: In practice, none.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is effectively a backout of bug 1594595, which, in practice did nothing. Strictly speaking, an uplift of the backout is not strictly needed. The difference it makes in practice is whether PHC is enabled by default when building with --enable-replace-malloc (which is not the default on beta).
• String changes made/needed:

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3888d3abdc8a

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9114748 [details]
Bug 1599337 - Make PHC nightly-only again. r=erahm

Disabling this feature for the RC build.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9cd6036ed800