Closed
Bug 1599373
Opened 5 years ago
Closed 4 years ago
Checking for http proxy should compare only 4 characters?
Categories
(Core :: Networking: HTTP, defect, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: dragana, Assigned: mbansal)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
I think here it should be 4:
https://searchfox.org/mozilla-central/source/netwerk/base/nsProtocolProxyService.cpp#1198
|
||
Comment 1•5 years ago
|
||
or len ? or a rewrite with mozilla::Tokenizer, to be safe? :)
Priority: -- → P2
Whiteboard: [necko-triaged]
Hello !!
Can I work on this bug ?
It seems that I only need to replace 5 with 4 ?
if (PL_strncasecmp(start, kProxyType_HTTP, 5) == 0) {
type = kProxyType_HTTP;
|
||
Updated•4 years ago
|
Assignee: nobody → mbansal
Status: NEW → ASSIGNED
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b3f21e88c485 Checking for http proxy should compare only 4 characters.r=dragana
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•