extensions badges got broken if counter is greater than 999
Categories
(WebExtensions :: Frontend, defect)
Tracking
(Not tracked)
People
(Reporter: leha-bot, Unassigned)
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
Usual web serfing in Nightly with 1000+ tabs, but after recent updates (10-15 days ago) the badge on "Count Tabs" extension became to show incorrect tabs count (110 instead of 1102 e.g.).
Actual results:
The extension badge have broken. Seems the text in extension badge just strips.
Expected results:
I expected that the extension show me the actual tabs count as it was 10-15 days ago.
https://github.com/sienori/Count-Tabs is the source of extension. As I saw then installed it many times ago, there was simple request for count of all tabs in JS.
|
||
Comment 2•5 years ago
|
||
Hi,
I wasn't able to reproduce this issue on Firefox 70.0.1 (20191030021342).
What Firefox version did you encounter this issue on ?
Please check if it also occurs on the latest Firefox Nightly: https://www.mozilla.org/en-US/firefox/channel/desktop/
Thanks!
|
||
Comment 3•5 years ago
|
||
My release install was version 69 and I could see 4 characters (9999 fits). On Nightly version 72 however I do see that most 4 character strings are truncated (1111 fits, but 1000 does not). I tested on Mac.
Knowing what version you noticed the regression on would still help, thanks!
Unfortunately I don't exactly know which nightly revision was the guilty one (seems this regression have become after late October), I have version "72.0a1 (2019-11-27) (64-bit)" right now. I could try to install some older releases to test it (if I found where I could it download :) https://www.mozilla.org/en-US/firefox/channel/desktop/#nightly returns latest nightly )
I just looked on recent changes in Nightly blog (https://blog.nightly.mozilla.org/2019/10/28/these-weeks-in-firefox-issue-67/) and suspect that this change: https://bugzilla.mozilla.org/show_bug.cgi?id=1576510 - could accidentaly introduce this regression. ("Toolbar badging is now accessible to screen reader users.")
|
|
||
Comment 6•4 years ago
|
||
Not a big deal if you don't know off hand the version. The version got set to 68 on the bug but it sounds like this is actually a recent regression.
Thanks for the info.
Seems that this bug is delivered to Developer Edition. The guilty revision is: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0 ID:20191202142314 (about dialog reports "72.0b1 (64-bit)")
|
|
||
Comment 8•4 years ago
|
||
Looks like a dupe got filed and has a patch on it.
Description
•