Closed Bug 1599432 Opened 2 years ago Closed 2 years ago

WebExtensionInspectedWindowFront eval should return ObjectFronts when needed (for non-primitive values)

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

This will then allow to pass the front directly to the objectInspector in devtools/client/inspector/extensions/components/ObjectValueGripView.js#55-57 and remove the ObjectInspector specifics in the inspector store (devtools/client/inspector/store.js#15-20 )

Blocks: 1500000
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The WebExtensionInspectedWindow front is modified in order
to be able to parse the eval response.
We're doing it in a similar fashion to the other fronts methods
that can return ObjectFronts: everything is handled client side,
by the front, since an evaluation result can return primitive values,
long string or grips, and we can't define this through protocol.js in
a readable manner.
Some functions and a component are renamed to better represent
what they're doing.

Blocks: 1609153
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b2f555ce334
Create ObjectFront for non-primitive expression result in inspector sidebar extension. r=rpl.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.