1599432 - WebExtensionInspectedWindowFront eval should return ObjectFronts when needed (for non-primitive values)

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

This will then allow to pass the front directly to the objectInspector in devtools/client/inspector/extensions/components/ObjectValueGripView.js#55-57 and remove the ObjectInspector specifics in the inspector store (devtools/client/inspector/store.js#15-20 )

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1599432 - Create ObjectFront for non-primitive expression result in inspector sidebar extension. r=rpl.

The WebExtensionInspectedWindow front is modified in order
to be able to parse the eval response.
We're doing it in a similar fashion to the other fronts methods
that can return ObjectFronts: everything is handled client side,
by the front, since an evaluation result can return primitive values,
long string or grips, and we can't define this through protocol.js in
a readable manner.
Some functions and a component are renamed to better represent
what they're doing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b2f555ce334
Create ObjectFront for non-primitive expression result in inspector sidebar extension. r=rpl.

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7b2f555ce334