Closed Bug 1599454 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20451 - Do not generate layout boxes for non-rendered foreignObject.

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20451 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20451
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Do not generate layout boxes for non-rendered foreignObject.

This change effectively re-introduces the code from [1] but only let it
affect layout tree building, not style computation, which was the reason
why the code was removed in the first place.

This also fixes the resolved style for width/height returned from
getComputedStyle() to return 'auto' for a computed value of 'auto'.
This matches the Firefox behavior.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1070137

Bug: 1027905
Change-Id: Ie324de5b0693beea3e6626a36b25f7274234d15b
Reviewed-on: https://chromium-review.googlesource.com/1935114
WPT-Export-Revision: 57f7c0bb415d3a9796ff967f1693b3bcc4123caa

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 1 subtests

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Gecko CI Results

Ran 1 tests and 1 subtests
OK : 1
PASS : 1

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9a10ea5f9be
[wpt PR 20451] - Do not generate layout boxes for non-rendered foreignObject., a=testonly

https://hg.mozilla.org/mozilla-central/rev/b9a10ea5f9be

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.