1599577 - Include default extension action icon in GV.

Status: RESOLVED INVALID

(GeckoView :: Extensions, defect, P2)

Description

[[ex-Mozilla] Agi Sferro | :agi]

toolkit's extension code uses chrome://browser/content/extension.svg as default icon for browser and page actions. This icon is not included in GV, we should probably move it to somewhere that's accessible for all platforms.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1352970#c11

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

I was pretty sure that we already have a bug filed which is aiming to remove some duplicates of the extension icon and also move extension.svg at toolkit level and so I looked for it today and it is "Bug 1421039 - Remove duplicate extension icons".

I'm currently adding it as a See Also, but the phabricator revision seems in progress and active (mstriemer commented recently, asking the contributor to apply some additional changes and rebase the patch to a recent mozilla-central tip) and so I think we may add Bug 1421039 a blocker for this issue (so that this could be just focused on covering the GeckoView bits of the changes needed).

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Yeah that sounds reasonable. I don't expect any more work to be needed after Bug 1421039 actually, as we now share most of the implementation with desktop.

Comment 4

[Ajitesh13]

I am currently working in Bug 1421039, after submitting a successful patch there, does some work need to be done here ?

Comment 5

[[:owlish] 🦉 PST]

The icon in question is already in toolkit.