1599582 - add minimum-scale=1.0 and initial-scale=1.0 to the FxA signup page

Status: VERIFIED FIXED

(Cloud Services :: Server: Firefox Accounts, defect, P1)

Description

[laustin]

Attachment: Screenshot_20191126-091227_Firefox.jpg

Steps to reproduce:
Install Firefox, sign out of FxA (if signed in), clear cache.
Open the following deeplink URL with Firefox set as your default browser: firefox://fxa-signin?entrypoint=fx-push-notification%26utm_source=leanplum-push-notification-test%26utm_campaign=android-push-notification-test

Expected behavior: FxA signup page resolves normally.
Actual behavior: FxA signup page resolves but is very small (screenshot attached).

Tested using:
Device: Galaxy Note 10+
Android OS Version: 9

Note that the deeplink schema was tested and validated in this ticket:
https://bugzilla.mozilla.org/show_bug.cgi?id=1522704

Comment 1

[athomas]

Sounds like this issue may be fixed in 68.2 beta https://bugzilla.mozilla.org/show_bug.cgi?id=1554598

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

What version of Firefox does this happen with? Would you mind trying again with 68.3?

Comment 3

[laustin]

Just checked on 68.3 with my Pixel 2 test device (Android 10), and this still appears to be an issue.

Note that the tiny page does not appear when clicking in to "Sign In" from the "Awesomescreen" card, only when trying to sign in from the "Settings" page in the app.

Tried clearing cache and restarting the phone and still tiny sign-in page.

Comment 4

[Sean Voisen (:svoisen)]

@Hiro: Any thoughts on this? (FWIW: I cannot reproduce on my Pixel 3a on Fennec 68.3.0.) I think it's sufficient to just load firefox://fxa-signin. I see the following viewport settings: width=device-width; user-scalable=0 Maybe it needs initial-scale as well?

Comment 5

[Sean Voisen (:svoisen)]

I'll put this in Core::Layout for now to shepherd it along, but not sure if it's a layout bug yet or just a bug with the page.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

It seems about:debugging on current nightly no longer able to connect with Fennec 68 so I can't check what exactly happens in the document right now.

(In reply to Sean Voisen (:svoisen) from comment #4)

@Hiro: Any thoughts on this? (FWIW: I cannot reproduce on my Pixel 3a on Fennec 68.3.0.) I think it's sufficient to just load firefox://fxa-signin. I see the following viewport settings: width=device-width; user-scalable=0 Maybe it needs initial-scale as well?

Adding minimum-scale=1.0 should solve this. initial-scale=1.0 would be also nice to have.

I will check what's going on there somehow.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

I gave up finding out which bug fixed this issue in mozilla-central(I believe this issue has already been fixed) since I couldn't build Fennec 68 locally. Given that it's not reliably reproducible, my best guess is it's bug 1575093,

Comment 8

[Diana Rus]

Hi I managed to constantly reproduce the issue with Samsung Galaxy Tab A (Android 9) and LG g7 fit (Android 8.1) on Firefox Release 68.4.0 with the steps to reproduce from bug1554598comment5 and with an extra note.
When going to re-login page, you don't wait for all the 3 welcome slides to load, you go directly to the menu and tap on Settings/Firefox Account/Account informative message.

Steps to reproduce:

1. Sign-in into Firefox account.
2. Clear data from the Android Settings.
3. Go to the re-login page without navigating between the welcome slides.

Note:

• Please view video.
• Did not manage to reproduce with the same steps on Firefox Beta 68.4b4.

Comment 9

[Sean Voisen (:svoisen)]

ESR is now at 68.4.1.

Seems like the best course of action is for someone to add minimum-scale=1.0 and initial-scale=1.0 to the FxA signup page viewport settings. They should probably be there anyway. I'm going to move this to that component to see if that's possible.

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

Firefox for Android::Firefox accounts is for the Java integration with Accounts.

Comment 11

[Wil Clouser [:clouserw]]

Is this an FxA bug? Is firefox://fxa-signin loading an FxA page or is that a form built-in?

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Firefox for Android does not have an in product page for it. The page is the accounts login page.

Comment 13

[Lauren Zugai]

I added the minimum-scale=1.0 tag for this. We already had initial-scale=1.0 present. I'm going to have our QA team verify the fix but please see https://github.com/mozilla/fxa/pull/4033 for more details.

Comment 14

[Wil Clouser [:clouserw]]

Assuming all goes well, this change will go live next Monday

Comment 15

[Vasilica Tamas, QA [:vtamas]]

Attachment: Screenshot_20200218-171249.png

The Sign-in page is correctly opened on Fennec 68.5.0 using:

• Google Pixel with (Android Q)
• Samsung Galaxy Note 8 with (Android 9)
• Moto G6 with (Android 9)

Based on the above mentioned I am marking this bug as Verified.