1599596 - Forcing update a revision without bug is failing

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

To reproduce

1. Clone version-control-tools
2. Make a change, create a commit associating the change with a bug id, e.g.: Bug 1592429: testing moz-phab bug
3. Push the change to phabricator: moz-phab
4. Make a new change, create a commit unassociated with a bug, e.g.: No bug: testing moz-phab bug
5. Push the change to phabricator: moz-phab -f
6. Make a change, amend the commit: hg amend
7. Push the change to phabricator: moz-phab -f

Submitting 2 commits for review:
(D54816) 7333:8a18d05c2d69 No bug: testing moz-phab bug
!! Missing Bug ID
!! Missing reviewers
(D54815) 7330:7f5bd6de72f7 Bug 1592429: testing moz-phab bug
!! Missing reviewers
Ignoring issues found with commits:

7333:8a18d05c2d69 No bug: testing moz-phab bug
- missing bug-id
Automatically submitting (as per submit.auto_submit in ~/.moz-phab-config)

Updating revision D54815:
7330:7f5bd6de72f7 Bug 1592429: testing moz-phab bug
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Updated an existing Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D54815

Included changes:
  M       hgext/mozext/__init__.py

Updating revision D54816:
7333:8a18d05c2d69 No bug: testing moz-phab bug
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Updated an existing Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D54816

Included changes:
  M       hgext/mozext/__init__.py
ERR-CONDUIT-CORE: Exception when processing transaction of type "bugzilla.bug-id": Error while reading "value": Expected string, got something else.

Comment 1

[Piotr Zalewa [:zalun]]

Please submit with a --no-arc switch.
I will investigate updating the revision using arcanist

Comment 2

[Piotr Zalewa [:zalun]]

If you try to submit a commit without any bug, please don't use --force, just add the --no-bug --no-arc switches.

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Bug 1599596 - Do not add bug-id transaction when updating. r=mhentges

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1599596: testing moz-phab bug

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1599596: checks commit bug-id before updating phab; r?zalun