Closed
Bug 1599615
Opened 5 years ago
Closed 5 years ago
Make some necko code less nsresult-happy.
Categories
(Core :: Networking, task, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Stuff that's infallible and not virtual has no reason to return an nsresult.
Depends on D54830
|
||
Updated•5 years ago
|
Assignee: nobody → emilio
|
||
Comment 2•5 years ago
|
||
Emilio, please establish a priority of this bug. Thanks.
Flags: needinfo?(emilio)
|
|
Assignee | |
Comment 3•5 years ago
|
||
I don't know how necko prioritizes bugs. This is just a cleanup, so P3 I guess?
Type: defect → task
Flags: needinfo?(emilio)
Priority: -- → P3
|
|
||
Comment 4•5 years ago
|
||
Good enough, thanks. Let you know the review will take a while for me. Too busy.
Whiteboard: [necko-triaged]
|
|
Assignee | |
Comment 5•5 years ago
|
||
Can you suggest another reviewer then? It should be straight-forward (I just wrote a static analysis to warn about non-virtual functions that only return NS_OK), and I'd rather not let the patch bitrot.
|
|
||
Comment 6•5 years ago
|
||
kershaw or valentin.
|
|
Assignee | |
Comment 7•5 years ago
|
||
Sounds good, thanks!
|
|
||
Updated•5 years ago
|
Attachment #9111767 -
Attachment description: Bug 1599615 - Make some necko code less nsresult-happy. r=honza → Bug 1599615 - Make some necko code less nsresult-happy. r=valentin,kershaw
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02b544b1570d Make some necko code less nsresult-happy. r=kershaw,valentin
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•